Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21866 )

Change subject: IMPALA-13415: Add a special testing mode to track Calcite 
progress
......................................................................


Patch Set 7:

(5 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/21866/7/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/21866/7/tests/common/impala_test_suite.py@757
PS7, Line 757: ,
flake8: E501 line too long (91 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21866/7/tests/common/impala_test_suite.py@793
PS7, Line 793: t
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21866/7/tests/common/impala_test_suite.py@826
PS7, Line 826: v
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21866/7/tests/conftest.py
File tests/conftest.py:

http://gerrit.cloudera.org:8080/#/c/21866/7/tests/conftest.py@181
PS7, Line 181: "
flake8: E501 line too long (91 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21866/7/tests/conftest.py@187
PS7, Line 187: )
flake8: E124 closing bracket does not match visual indentation



--
To view, visit http://gerrit.cloudera.org:8080/21866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I453c219c22b6cbc253574e0467d2c0d7b1fac092
Gerrit-Change-Number: 21866
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Wed, 30 Oct 2024 23:12:28 +0000
Gerrit-HasComments: Yes

Reply via email to