Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21866 )
Change subject: IMPALA-13415: Add a special testing mode to track Calcite progress ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/21866/9/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21866/9/tests/common/impala_test_suite.py@879 PS9, Line 879: os.makedirs(output_directory) Do we want to create the directory all the time even if the user supplies it? Or just when the default is None? I'm thinking the latter since I'm not sure it's a great idea creating a directory outside of the Impala environment. But I can be convinced it's ok. -- To view, visit http://gerrit.cloudera.org:8080/21866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I453c219c22b6cbc253574e0467d2c0d7b1fac092 Gerrit-Change-Number: 21866 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sat, 02 Nov 2024 13:39:03 +0000 Gerrit-HasComments: Yes
