Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21866 )
Change subject: IMPALA-13415: Add a special testing mode to track Calcite progress ...................................................................... Patch Set 9: One thing I was still hoping that this report would deal with is that I'd like to have the ability to modify the query slightly (or the return types) which get us the results we like. This won't mean that the test succeeded, but with a small modification, the test will succeed. These things might be something we might or might not address. One small example is the factorial function. Impala supports "select 3!". The Calcite parser supports "select factorial(3)". That might wind up being easy to change in the parser, but I'm guessing factorial isn't a highly used function, so there's some chance we'll never support it. My proposal was to add a "CALCITE_PLANNER_<section>" section. If this is detected, bump the failed count but count it as a "modified with success" query. Is this planned for a future commit? I have a draft (off of an older version of this submit requst) here: https://gerrit.cloudera.org/#/c/21937/ -- To view, visit http://gerrit.cloudera.org:8080/21866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I453c219c22b6cbc253574e0467d2c0d7b1fac092 Gerrit-Change-Number: 21866 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sat, 02 Nov 2024 13:20:41 +0000 Gerrit-HasComments: No
