Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 )
Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks ...................................................................... Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/10396/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10396/2//COMMIT_MSG@14 PS2, Line 14: decisions. > Can you mention that this assumes that the per-process memory limit does no Done http://gerrit.cloudera.org:8080/#/c/10396/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/10396/2/be/src/scheduling/admission-controller.cc@49 PS2, Line 49: int64_t GetProcMemLimit() { > This is dead code now Done http://gerrit.cloudera.org:8080/#/c/10396/2/be/src/scheduling/admission-controller.cc@152 PS2, Line 152: const string HOST_MEM_NOT_AVAILABLE = "Not enough memory available on host $0." > Maybe this error message should include the total process memory limit, e.g good idea. Done. http://gerrit.cloudera.org:8080/#/c/10396/2/be/src/scheduling/admission-controller.cc@450 PS2, Line 450: > Unnecessary vertical whitespace Done http://gerrit.cloudera.org:8080/#/c/10396/2/be/src/scheduling/admission-controller.cc@458 PS2, Line 458: > Vertical whitespace Done http://gerrit.cloudera.org:8080/#/c/10396/2/be/src/scheduling/query-schedule.h File be/src/scheduling/query-schedule.h: http://gerrit.cloudera.org:8080/#/c/10396/2/be/src/scheduling/query-schedule.h@69 PS2, Line 69: // The process memory limit of this backend. > Maybe mention that it's the value obtained from the statestore during sched Done http://gerrit.cloudera.org:8080/#/c/10396/2/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/10396/2/bin/start-impala-cluster.py@87 PS2, Line 87: seperated > separated Done http://gerrit.cloudera.org:8080/#/c/10396/2/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/10396/2/tests/custom_cluster/test_admission_controller.py@429 PS2, Line 429: 1000 > Can we set this lower? Is there a reason that it needs to sit in the queue forgot to update that. http://gerrit.cloudera.org:8080/#/c/10396/2/tests/custom_cluster/test_admission_controller.py@431 PS2, Line 431: def test_heterogeneous_proc_mem_limit(self, vector): > Can we add a 3GB query that succeeds? E.g. with num_nodes=1, submitted to o Done http://gerrit.cloudera.org:8080/#/c/10396/2/tests/custom_cluster/test_admission_controller.py@433 PS2, Line 433: mem limits of each impalad""" > Maybe add an extra sentence to explain the concept of the test. e.g. "Start Done http://gerrit.cloudera.org:8080/#/c/10396/2/tests/custom_cluster/test_admission_controller.py@434 PS2, Line 434: # Choose a query that runs on all 3 backends. > Are all these queries submitted to the first impalad? It's not clear if tha modified a test to send a query to a different impalad. (check the queuing test) -- To view, visit http://gerrit.cloudera.org:8080/10396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb72eee790cc17466bbfa82e30f369a65f2b060e Gerrit-Change-Number: 10396 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 17 May 2018 21:18:08 +0000 Gerrit-HasComments: Yes
