Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 )
Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10396/3/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/10396/3/be/src/scheduling/admission-controller.cc@408 PS3, Line 408: pair<const TNetworkAddress*, int64_t> min_proc_mem_limit = : make_pair(nullptr, std::numeric_limits<int64_t>::max()); @Tim: let me know if you decide not to adopt this pattern for your patch for IMPALA-6035 -- To view, visit http://gerrit.cloudera.org:8080/10396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb72eee790cc17466bbfa82e30f369a65f2b060e Gerrit-Change-Number: 10396 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 17 May 2018 21:24:00 +0000 Gerrit-HasComments: Yes
