Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 )
Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/10396/3/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/10396/3/be/src/scheduling/admission-controller.cc@408 PS3, Line 408: pair<const TNetworkAddress*, int64_t> min_proc_mem_limit = : make_pair(nullptr, std::numeric_limits<int64_t>::max()); > @Tim: let me know if you decide not to adopt this pattern for your patch fo WFM http://gerrit.cloudera.org:8080/#/c/10396/3/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/10396/3/tests/custom_cluster/test_admission_controller.py@454 PS3, Line 454: exec_options['mem_limit'] = "3G" Does this line do anything? It's already set to 3G above. Is it intentional that num_nodes=1 still at this point? It might be easier to follow if we just created a copy of exec_options for each query rather than mutating the one version. We use the copy() function in a few other tests for this purpose. What do you think? http://gerrit.cloudera.org:8080/#/c/10396/3/tests/custom_cluster/test_admission_controller.py@473 PS3, Line 473: "2.00 GB but only 1.00 GB out of 2.00 GB was available.", str(e)), str(e) long line -- To view, visit http://gerrit.cloudera.org:8080/10396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb72eee790cc17466bbfa82e30f369a65f2b060e Gerrit-Change-Number: 10396 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 18 May 2018 19:20:34 +0000 Gerrit-HasComments: Yes
