Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21701 )
Change subject: IMPALA-12957: Support reading Inf and NaN from JSON ...................................................................... IMPALA-12957: Support reading Inf and NaN from JSON Despite the fact that special values such as Inf and NaN are not supported in standard JSON (they are considered invalid values), rapidjson does support them. However, it requires the parsing flag 'kParseNanAndInfFlag' to be enabled. This patch enables the flag to allows JsonParser to parse special numbers like Inf and NaN. Corresponding modifications have also been made to JsonSkipper to maintain consistent behavior when zero slots scans. Additionally, due to a minor issue in rapidjson v1.1.0 when parsing Inf and NaN, this patch also updates the rapidjson version to include the corresponding fix (see https://gerrit.cloudera.org/#/c/21980/). Testing: - Added and passed relevant test cases (BE, E2E). Change-Id: I05ee7c7c7fb7e78fff9570f659ce2d13c94a4e10 Reviewed-on: http://gerrit.cloudera.org:8080/21701 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/json/json-parser-test.cc M be/src/exec/json/json-parser.cc M be/src/exec/json/json-parser.h M bin/impala-config.sh M testdata/data/json_test/malformed.json M testdata/data/json_test/overflow.json M testdata/workloads/functional-query/queries/QueryTest/malformed_json.test M testdata/workloads/functional-query/queries/QueryTest/overflow_json.test 8 files changed, 50 insertions(+), 21 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21701 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I05ee7c7c7fb7e78fff9570f659ce2d13c94a4e10 Gerrit-Change-Number: 21701 Gerrit-PatchSet: 5 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]>
