Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21701 )
Change subject: IMPALA-12957: Support reading Inf and NaN from JSON ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21701/2/be/src/exec/json/json-parser.cc File be/src/exec/json/json-parser.cc: http://gerrit.cloudera.org:8080/#/c/21701/2/be/src/exec/json/json-parser.cc@a340 PS2, Line 340: : > nit: can we keep some comments about Inf and NaN, and mention we have enabl Agree, L340 and L341 can stay. -- To view, visit http://gerrit.cloudera.org:8080/21701 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05ee7c7c7fb7e78fff9570f659ce2d13c94a4e10 Gerrit-Change-Number: 21701 Gerrit-PatchSet: 2 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 04 Nov 2024 18:01:53 +0000 Gerrit-HasComments: Yes
