Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21701 )
Change subject: IMPALA-12957: Support reading Inf and NaN from JSON ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21701/3/be/src/exec/json/json-parser-test.cc File be/src/exec/json/json-parser-test.cc: http://gerrit.cloudera.org:8080/#/c/21701/3/be/src/exec/json/json-parser-test.cc@191 PS3, Line 191: TestSkip("Inf", TYPE_NUMBER); : TestSkip("-Infinity", TYPE_NUMBER); : TestSkip("NaN", TYPE_NUMBER); nit: Is case matter or not (nan, inf, infinity)? -- To view, visit http://gerrit.cloudera.org:8080/21701 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05ee7c7c7fb7e78fff9570f659ce2d13c94a4e10 Gerrit-Change-Number: 21701 Gerrit-PatchSet: 3 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 05 Nov 2024 15:46:35 +0000 Gerrit-HasComments: Yes
