Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 8: (2 comments) > Patch Set 7: > > (2 comments) > > I left some thoughts on how to generate a Ranger audit event that accurately > reflects whether the requesting user is authorized to execute the KILL QUERY > statement. > > I think for this patch it's okay if we produce an accurate Ranger audit event > only when the requesting user has the ALL privilege on SERVER. We could > resolve the general case, i.e., requesting user is a non-administrative user, > in a follow-up JIRA. > > Thanks! Thanks for reviewing and sharing your ideas! http://gerrit.cloudera.org:8080/#/c/21930/7/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21930/7/be/src/service/client-request-state.cc@2490 PS7, Line 2490: coordinato > nit: coordinator Thanks! Fixed. http://gerrit.cloudera.org:8080/#/c/21930/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/21930/6/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@185 PS6, Line 185: setRetainAudits(false) > Regarding how to generate a Ranger audit event that accurately reflects whe Thanks! I've learned a lot from your comments! I think your idea makes sense. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 8 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 12 Nov 2024 02:37:13 +0000 Gerrit-HasComments: Yes
