Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 11: (3 comments) > Patch Set 9: > > (5 comments) > > This change is looking good. A few minor comments/questions to address. > > Also, the new kill query statements will need to be automatically admitted > through admission control. Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/21930/9/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21930/9/be/src/service/client-request-state.cc@2466 PS9, Line 2466: Status ClientRequestState::TryKillQueryLocally( > This function is somewhat difficult to follow because it take a few differe Thanks! Splitted it into TryKillQueryLocally() and TryKillQueryRemotely(). http://gerrit.cloudera.org:8080/#/c/21930/9/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/21930/9/be/src/service/impala-server.h@729 PS9, Line 729: class SecretArg; > I'm not seeing that this friend class declaration is needed. This is because ClientRequestState::TryKillQueryLocally() needs to call two private methods of ImpalaServer: CancelInternal() and UnregisterQuery(). Added a comment. http://gerrit.cloudera.org:8080/#/c/21930/9/fe/src/main/java/org/apache/impala/analysis/StatementBase.java File fe/src/main/java/org/apache/impala/analysis/StatementBase.java: http://gerrit.cloudera.org:8080/#/c/21930/9/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@280 PS9, Line 280: * This method is designed to allow custom authorization exception handling. A > Please expand this comment to explain why this exception is being ignored a Thanks! Added doc to explain it. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 11 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 16 Dec 2024 10:04:02 +0000 Gerrit-HasComments: Yes
