Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/#/c/21930/8/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21930/8/be/src/service/client-request-state.cc@2477 PS8, Line 2477: // In this case, no more RPCs are needed. The following logic is similar to > Thanks! Removed. Done http://gerrit.cloudera.org:8080/#/c/21930/8/be/src/service/client-request-state.cc@2481 PS8, Line 2481: query_id, true, &Status::CANCELLED); > Thanks! Will try to resolve the conflicts after https://gerrit.cloudera.org Done http://gerrit.cloudera.org:8080/#/c/21930/8/be/src/service/client-request-state.cc@2489 PS8, Line 2489: > Thanks! Added. Done http://gerrit.cloudera.org:8080/#/c/21930/8/be/src/service/client-request-state.cc@2491 PS8, Line 2491: // the kill request to all other coordinators. > Thanks! Changed. Done http://gerrit.cloudera.org:8080/#/c/21930/8/be/src/service/client-request-state.cc@2493 PS8, Line 2493: TUniqueIdToUniqueIdPB(query_id, &query_id_pb); > Thanks! Removed the vector variable. Done http://gerrit.cloudera.org:8080/#/c/21930/8/be/src/service/client-request-state.cc@2507 PS8, Line 2507: ExecEnv::GetInst > Thanks! Combined the two lines with the `auto` keyword. Is that OK? Yes, that definitely works too. I like using auto better because the variable name remains longer and thus more descriptive. http://gerrit.cloudera.org:8080/#/c/21930/8/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/21930/8/common/thrift/Frontend.thrift@729 PS8, Line 729: // Request for "KILL QUERY" statements. > Thanks! Added. Done -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 9 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 13 Dec 2024 21:42:13 +0000 Gerrit-HasComments: Yes
