Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21803 )

Change subject: IMPALA-915: Support cancel queries during planning
......................................................................


Patch Set 14:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21803/12/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/21803/12/tests/webserver/test_web_pages.py@1085
PS12, Line 1085:     delay_created_action = 
"impalad_load_tables_delay:SLEEP@5000"
> I think the solution there should be the same: send a signal to catalogd to
I have something that works for cancelling 'refresh metadata', just working on 
a test for it.

Cancelling 'describe' turns out to be a bit more work, because 
TGetPartialCatalogObjectRequest doesn't include a query ID. I'm going to look 
at adding one - probably by tracking the query ID used with a thread in the 
frontend and adding TCatalogServiceRequestHeader to the request.



--
To view, visit http://gerrit.cloudera.org:8080/21803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86
Gerrit-Change-Number: 21803
Gerrit-PatchSet: 14
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 19 Nov 2024 23:39:06 +0000
Gerrit-HasComments: Yes

Reply via email to