Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries during planning ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/21803/12/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21803/12/tests/webserver/test_web_pages.py@1085 PS12, Line 1085: delay_created_action = "impalad_load_tables_delay:SLEEP@5000" > Thanks, I'll look into both of those. It looks like both are blocked by the catalog operation: 1. refresh: frontend is cancelled, but it still waits on the backend RESET_METADATA request to finish in ClientRequestState::BlockOnWait. Still looking into why; the right thing here probably is to - after CancelExecRequest - also send a Cancel operation to catalogd for the query ID, which would need to have some way to identify what operations are on-going for a query ID and interrupt them. 2. describe: appears to fail to interrupt loadWithCaching. That should be easier to fix. We use a library called Untinterruptibles that we probably need to stop using. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 18 Nov 2024 21:34:52 +0000 Gerrit-HasComments: Yes
