Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries during planning ...................................................................... Patch Set 12: (4 comments) This is a great feature that we have been waiting for years! http://gerrit.cloudera.org:8080/#/c/21803/12/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java File fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java: http://gerrit.cloudera.org:8080/#/c/21803/12/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java@305 PS12, Line 305: // Ignore nit: we can remove all these "Ignore" comments http://gerrit.cloudera.org:8080/#/c/21803/12/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/21803/12/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java@195 PS12, Line 195: Frontend.checkCancelled(); Should we add a catalogd RPC for coordinator to cancel the metadata loading in catalogd? I'm not sure how the patch works in local-catalog mode since the coordinator could be blocked in the getPartialCatalogObject RPC, which might be waiting for the table to be loaded. https://github.com/apache/impala/blob/fe3f82179fa0726af0645d01f90a2bf966175b75/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java#L451 https://github.com/apache/impala/blob/fe3f82179fa0726af0645d01f90a2bf966175b75/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java#L3884-L3886 http://gerrit.cloudera.org:8080/#/c/21803/12/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21803/12/tests/webserver/test_web_pages.py@1030 PS12, Line 1030: functional_parquet.alltypes This test runs concurrently with other e2e tests. We'd better use a unique table name to avoid impacting other tests. http://gerrit.cloudera.org:8080/#/c/21803/12/tests/webserver/test_web_pages.py@1085 PS12, Line 1085: delay_created_action = "impalad_load_tables_delay:SLEEP@5000" Can we add more tests setting catalogd_load_metadata_delay or catalogd_refresh_hdfs_listing_delay to an extremely large value, e.g. 3600000? -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 11 Nov 2024 07:10:47 +0000 Gerrit-HasComments: Yes
