Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 16: (5 comments) http://gerrit.cloudera.org:8080/#/c/21803/15/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/21803/15/be/src/catalog/catalog-server.cc@458 PS15, Line 458: VLOG_RPC << "Cancel(): request=" << ThriftDebugString(req); > Please make sure you don't output sensitive data with ThriftDebugString(). Same as every other request/response log in this file. http://gerrit.cloudera.org:8080/#/c/21803/15/be/src/catalog/catalog-server.cc@467 PS15, Line 467: VLOG_RPC << "Cancel(): response=" << ThriftDebugStringNoThrow(resp); > Please make sure you don't output sensitive data with ThriftDebugString(). Same as every other request/response log in this file. http://gerrit.cloudera.org:8080/#/c/21803/15/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: PS15: > This file is used in communication between impalad and catalogd/statestore. Only optional fields are added. http://gerrit.cloudera.org:8080/#/c/21803/15/common/thrift/CatalogService.thrift@761 PS15, Line 761: 1: required CatalogServiceVersion protocol_version = CatalogServiceVersion.V2 > Modifying/adding this required field might break the compatibility between New struct. http://gerrit.cloudera.org:8080/#/c/21803/15/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21803/15/tests/custom_cluster/test_web_pages.py@511 PS15, Line 511: @CustomClusterTestSuite.with_args( > flake8: E302 expected 2 blank lines, found 1 Ack -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 16 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 21 Nov 2024 17:02:27 +0000 Gerrit-HasComments: Yes
