Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 17: (11 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21803/17/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/21803/17/be/src/catalog/catalog-server.cc@458 PS17, Line 458: VLOG_RPC << "Cancel(): request=" << ThriftDebugString(req); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/21803/17/be/src/catalog/catalog-server.cc@467 PS17, Line 467: VLOG_RPC << "Cancel(): response=" << ThriftDebugStringNoThrow(resp); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/21803/17/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: PS17: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new optional fields can be added. http://gerrit.cloudera.org:8080/#/c/21803/17/common/thrift/CatalogService.thrift@761 PS17, Line 761: 1: required CatalogServiceVersion protocol_version = CatalogServiceVersion.V2 Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/21803/17/tests/util/web_pages_util.py File tests/util/web_pages_util.py: http://gerrit.cloudera.org:8080/#/c/21803/17/tests/util/web_pages_util.py@60 PS17, Line 60: def get_queries(nth=0): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21803/17/tests/util/web_pages_util.py@66 PS17, Line 66: def cancel(query_id, nth=0): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21803/17/tests/util/web_pages_util.py@75 PS17, Line 75: def wait_for_state(state, nth=0): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21803/17/tests/util/web_pages_util.py@87 PS17, Line 87: def assert_query_stopped(query_id, nth=0): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21803/17/tests/util/web_pages_util.py@98 PS17, Line 98: def run(client, query, queue): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21803/17/tests/util/web_pages_util.py@105 PS17, Line 105: def start(client, query): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21803/17/tests/util/web_pages_util.py@112 PS17, Line 112: def join(proc, queue): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 17 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 21 Nov 2024 19:01:33 +0000 Gerrit-HasComments: Yes
