Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22091 )
Change subject: IMPALA-13531: Calcite CTE frontend ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/22091/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22091/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@105 PS1, Line 105: // Update ImpalaCTEConsumers with relevant CTEProducer for PlanNode creation. This part is messy. There's probably a way to do this with Calcite rules that I need to figure out. http://gerrit.cloudera.org:8080/#/c/22091/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@291 PS1, Line 291: return new ImpalaSequence(inputs); This should be smarter. ImpalaSequence nodes should be placed right above where they're needed, not at the top of the plan. -- To view, visit http://gerrit.cloudera.org:8080/22091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0840c0859d2fe25628d799a18d302cee1eb36e8 Gerrit-Change-Number: 22091 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 21 Nov 2024 22:41:45 +0000 Gerrit-HasComments: Yes
