Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22091 )
Change subject: IMPALA-13531: Calcite CTE frontend ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/22091/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22091/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@297 PS4, Line 297: return new ImpalaSequence(inputs); This could be improved to move Sequence nodes further down in the tree, closer to where they're needed. However that requires a relatively complicated algorithm to identify, and will be thrown out in distributed plans (where each producer will be in an independent fragment). http://gerrit.cloudera.org:8080/#/c/22091/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@373 PS4, Line 373: if (!LOG.isDebugEnabled()) return; This should be part of the parent patch. -- To view, visit http://gerrit.cloudera.org:8080/22091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0840c0859d2fe25628d799a18d302cee1eb36e8 Gerrit-Change-Number: 22091 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2024 23:57:01 +0000 Gerrit-HasComments: Yes
