Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22045 )
Change subject: IMPALA-13535: Add script to restore stats on PlannerTest ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22045/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22045/3//COMMIT_MSG@16 PS3, Line 16: This patch provide a python script to fix the table stats information in It's not clear to me how this script should be used. Do you run it after any changes, and it ensures stats don't change unless something about our estimation changes? http://gerrit.cloudera.org:8080/#/c/22045/3//COMMIT_MSG@21 PS3, Line 21: This patch also fixed table size for tests under Is this the only reason stats changed in the test files? http://gerrit.cloudera.org:8080/#/c/22045/3/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/22045/3/fe/src/main/java/org/apache/impala/catalog/Table.java@223 PS3, Line 223: protected double testMetadataScale_ = -1.0; I'm not clear why this is changed. Is it called out in the commit message? -- To view, visit http://gerrit.cloudera.org:8080/22045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27bab7cee93880cd59f01b9c2d1614dfcabdc682 Gerrit-Change-Number: 22045 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 22 Nov 2024 18:51:12 +0000 Gerrit-HasComments: Yes
