Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22045 )
Change subject: IMPALA-13535: Add script to restore stats on PlannerTest ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22045/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22045/3//COMMIT_MSG@16 PS3, Line 16: This patch provide a python script to fix the table stats information in > I expect contributor to run ./tesdata/bin/restore-stats-on-planner-test.py Maybe we should have or update a README then. http://gerrit.cloudera.org:8080/#/c/22045/3//COMMIT_MSG@21 PS3, Line 21: This patch also fixed table size for tests under > Yes, for all changes under tpcds_cpu_cost/. I guess I'm still not clear what the script is setting them to. I see in the script it has some hard-coded, so it'd be nice to call that out in the commit message. -- To view, visit http://gerrit.cloudera.org:8080/22045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27bab7cee93880cd59f01b9c2d1614dfcabdc682 Gerrit-Change-Number: 22045 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 22 Nov 2024 19:08:18 +0000 Gerrit-HasComments: Yes
