Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22045 )
Change subject: IMPALA-13535: Add script to restore stats on PlannerTest ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/22045/6/testdata/workloads/functional-planner/queries/PlannerTest/agg-node-max-mem-estimate.test File testdata/workloads/functional-planner/queries/PlannerTest/agg-node-max-mem-estimate.test: http://gerrit.cloudera.org:8080/#/c/22045/6/testdata/workloads/functional-planner/queries/PlannerTest/agg-node-max-mem-estimate.test@1217 PS6, Line 1217: HDFS partitions=1824/1824 files=1824 size=200.96MB Not sure why gerrit-auto-critic does not complain about this before. Jenkins also persistently running it with python2 even though I already change the shebang to python3. https://jenkins.impala.io/job/gerrit-auto-critic/18475/console https://jenkins.impala.io/job/gerrit-auto-critic/18474/console But I run it in my local machine and it produce comments. ./bin/jenkins/critique-gerrit-review.py --dryrun Requirement already satisfied: flake8==3.9.2 in ./gerrit_critic_venv/lib/python3.8/site-packages (3.9.2) Requirement already satisfied: flake8-diff==0.2.2 in ./gerrit_critic_venv/lib/python3.8/site-packages (0.2.2) Requirement already satisfied: mccabe<0.7.0,>=0.6.0 in ./gerrit_critic_venv/lib/python3.8/site-packages (from flake8==3.9.2) (0.6.1) Requirement already satisfied: pycodestyle<2.8.0,>=2.7.0 in ./gerrit_critic_venv/lib/python3.8/site-packages (from flake8==3.9.2) (2.7.0) Requirement already satisfied: pyflakes<2.4.0,>=2.3.0 in ./gerrit_critic_venv/lib/python3.8/site-packages (from flake8==3.9.2) (2.3.1) Requirement already satisfied: blessings in ./gerrit_critic_venv/lib/python3.8/site-packages (from flake8-diff==0.2.2) (1.7) Requirement already satisfied: six in ./gerrit_critic_venv/lib/python3.8/site-packages (from flake8-diff==0.2.2) (1.16.0) Requirement already satisfied: argparse in ./gerrit_critic_venv/lib/python3.8/site-packages (from flake8-diff==0.2.2) (1.4.0) Updated 1 path from the index { "comments": { "testdata/workloads/functional-planner/queries/PlannerTest/agg-node-max-mem-estimate.test": [ { "message": "Table numRows and totalSize is changed in this planner test. It is unnecessary to change them. Consider running testdata/bin/restore-stats-on-planner-tests.py script to restore them to consistent values.", "line": 0, "side": "REVISION" } ] }, "message": "gerrit-auto-critic failed. You can reproduce it locally using command:\n\n python2 bin/jenkins/critique-gerrit-review.py --dryrun\n\nTo run it, you might need a virtual env with virtualenv installed." } -- To view, visit http://gerrit.cloudera.org:8080/22045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27bab7cee93880cd59f01b9c2d1614dfcabdc682 Gerrit-Change-Number: 22045 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 23 Nov 2024 00:01:00 +0000 Gerrit-HasComments: Yes
