Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21825 )
Change subject: IMPALA-889: Add trim() function matching ANSI SQL definition ...................................................................... Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/21825/17/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: http://gerrit.cloudera.org:8080/#/c/21825/17/docs/topics/impala_string_functions.xml@1808 PS17, Line 1808: TRIM(STRING a), TRIM({[LEADING / TRAILING / BOTH] | [STRING chars_to_trim]} FROM STRING a) > > TRIM([LEADING | TRAILING | BOTH] [STRING chars_to_trim] FROM STRING a) Maybe this? TRIM({{LEADING | TRAILING | BOTH} [STRING chars_to_trim] | STRING chars_to_trim} FROM STRING a) It's a little pedantic and maybe harder to see what actual syntax should look like. The examples later may be enough to clarify that. http://gerrit.cloudera.org:8080/#/c/21825/17/docs/topics/impala_string_functions.xml@1834 PS17, Line 1834: <codeph>{LRB}TRIM(string)</codeph>; > "LTRIM, RTRIM or BTRIM", but it should be with pipe sign: Ok, that'b be fine. http://gerrit.cloudera.org:8080/#/c/21825/17/docs/topics/impala_string_functions.xml@1839 PS17, Line 1839: <codeph>BTRIM(string, charset)</codeph>; Why is this just BTRIM? -- To view, visit http://gerrit.cloudera.org:8080/21825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c4fa6d0d8d0684c4b6d8dac8fd531d205e4f7b4 Gerrit-Change-Number: 21825 Gerrit-PatchSet: 17 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2024 18:46:57 +0000 Gerrit-HasComments: Yes
