Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21825 )
Change subject: IMPALA-889: Add trim() function matching ANSI SQL definition ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/21825/16/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/21825/16/fe/src/main/cup/sql-parser.cup@3845 PS16, Line 3845: trim_option ::= https://en.wikipedia.org/wiki/List_of_SQL_reserved_words shows these all as pretty common reserved keywords. We should update impala_reserved_words.html. I would have thought new keywords should only happen on major versions, but Impala doesn't seem to follow that. http://gerrit.cloudera.org:8080/#/c/21825/16/fe/src/main/cup/sql-parser.cup@3868 PS16, Line 3868: if (fn_name.toString().toLowerCase().endsWith("extract")) { Why endsWith rather than equals (or equalsIgnoreCase)? -- To view, visit http://gerrit.cloudera.org:8080/21825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c4fa6d0d8d0684c4b6d8dac8fd531d205e4f7b4 Gerrit-Change-Number: 21825 Gerrit-PatchSet: 16 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2024 23:34:26 +0000 Gerrit-HasComments: Yes
