Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21825 )
Change subject: IMPALA-889: Add trim() function matching ANSI SQL definition ...................................................................... Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/21825/17/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: http://gerrit.cloudera.org:8080/#/c/21825/17/docs/topics/impala_string_functions.xml@1808 PS17, Line 1808: TRIM(STRING a), TRIM({[LEADING / TRAILING / BOTH] | [STRING chars_to_trim]} FROM STRING a) The curly braces ('{', '}') are a little unusual, but this syntax is also new for function calls. What this says to me is: you can use one of LEADING/TRAILING/BOTH or STRING chars_to_trim. That doesn't quite match the actual syntax. What I'd put here is TRIM([LEADING | TRAILING | BOTH] [STRING chars_to_trim] FROM STRING a) That says you can optionally specify "where" (as one of LEADING/TRAILING/BOTH) and optionally specify a trim character set. This better matches the syntax definition in file:///Users/msmith2/Developer/Impala/docs/build/asf-site-html/topics/impala_select.html and is a bit less busy. http://gerrit.cloudera.org:8080/#/c/21825/17/docs/topics/impala_string_functions.xml@1834 PS17, Line 1834: <codeph>{LRB}TRIM(string)</codeph>; What's {LRB}? -- To view, visit http://gerrit.cloudera.org:8080/21825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c4fa6d0d8d0684c4b6d8dac8fd531d205e4f7b4 Gerrit-Change-Number: 21825 Gerrit-PatchSet: 17 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 22 Nov 2024 22:24:01 +0000 Gerrit-HasComments: Yes
