Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22118 )
Change subject: IMPALA-13536: Fix Workload Management Init with Catalog HA ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22118/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22118/1//COMMIT_MSG@14 PS1, Line 14: When the standby daemon became active, the first catalogd update was : finally received, and the workload management initialization process : ran a second time in the newly active daemon because this daemon : saw that it was active. This is the bad behavior? http://gerrit.cloudera.org:8080/#/c/22118/1//COMMIT_MSG@19 PS1, Line 19: The catalogd workload management initialization code now waits until : the active catalogd has been determined. At that point, the standby : daemon skips workload management initialization while the : active daemon runs it after it receives the first catalog update. This is the corrected behavior? http://gerrit.cloudera.org:8080/#/c/22118/1/tests/custom_cluster/test_workload_mgmt_init.py File tests/custom_cluster/test_workload_mgmt_init.py: http://gerrit.cloudera.org:8080/#/c/22118/1/tests/custom_cluster/test_workload_mgmt_init.py@583 PS1, Line 583: # Assert only 1 catalog ran workload management initialization. : assert init_logs[0] is None or init_logs[1] is None, "Both catalogds ran workload " \ : "management initialization" : I think Standby CatalogD should explicitly log that it skip workload management initialization because it is not the first CatalogD that selected as an active one. -- To view, visit http://gerrit.cloudera.org:8080/22118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3797a0a9cf0b8ae844d9b7d46b607d93824f69a Gerrit-Change-Number: 22118 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2024 21:21:31 +0000 Gerrit-HasComments: Yes
