Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22118 )
Change subject: IMPALA-13536: Fix Workload Management Init with Catalog HA ...................................................................... IMPALA-13536: Fix Workload Management Init with Catalog HA When running an Impala cluster with catalogd HA enabled, the standby catalogd would go into a loop waiting for the first catalog update to arrive repeatedly logging the same error and never joining the server thread defined in catalogd-main.cc. Before this patch, when the standby daemon became active, the first catalogd update was finally received, and the workload management initialization process ran a second time in the newly active daemon because this daemon saw that it was active. This patch modifies the catalogd workload management initialization code so it waits until the active catalogd has been determined. At that point, the standby daemon skips workload management initialization while the active daemon runs it after it receives the first catalog update. Testing was accomplished by modifying the workload management initialization custom cluster tests to assert that the init process is not re-run when a catalogd switches from standby to active and also to remove the assumption that the first catalogd was active. The test_catalog_ha test was deleted since all its assertions are handled by the setup_method of the new TestWorkloadManagementCatalogHA class. Ozone tests with and without erasure coding were also ran and passed. Change-Id: Id3797a0a9cf0b8ae844d9b7d46b607d93824f69a Reviewed-on: http://gerrit.cloudera.org:8080/22118 Reviewed-by: Riza Suminto <[email protected]> Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/catalog/catalog-server.cc M be/src/catalog/catalog-server.h M be/src/catalog/catalogd-main.cc M be/src/catalog/workload-management-init.cc M tests/common/impala_test_suite.py M tests/custom_cluster/test_workload_mgmt_init.py 6 files changed, 132 insertions(+), 73 deletions(-) Approvals: Riza Suminto: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/22118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id3797a0a9cf0b8ae844d9b7d46b607d93824f69a Gerrit-Change-Number: 22118 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
