Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22118 )
Change subject: IMPALA-13536: Fix Workload Management Init with Catalog HA ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/22118/2/be/src/catalog/workload-management-init.cc File be/src/catalog/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/22118/2/be/src/catalog/workload-management-init.cc@502 PS2, Line 502: The first expression evaluates to true when the first catalog update is sent. The first expression evaluates to true when the active CatalogD has sent its first catalog update. http://gerrit.cloudera.org:8080/#/c/22118/2/be/src/catalog/workload-management-init.cc@503 PS2, Line 503: coordinator CatalogD http://gerrit.cloudera.org:8080/#/c/22118/2/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22118/2/tests/common/impala_test_suite.py@1411 PS2, Line 1411: matches.append(None) Instead of artificially appending None, you can make log line for both Active and Standby CatalogD to have common prefix and capture the prefix instead. For example: Active: Workload management initialization is complete. This is an Active Catalog. Standby: Workload management initialization is skipped. This is a Standby Catalog. http://gerrit.cloudera.org:8080/#/c/22118/1/tests/custom_cluster/test_workload_mgmt_init.py File tests/custom_cluster/test_workload_mgmt_init.py: http://gerrit.cloudera.org:8080/#/c/22118/1/tests/custom_cluster/test_workload_mgmt_init.py@583 PS1, Line 583: assert len(init_logs) == 2, "Expected length of catalogd matches to be '2' but " \ : "was '{}'".format(len(init_logs)) : : > Done Done -- To view, visit http://gerrit.cloudera.org:8080/22118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3797a0a9cf0b8ae844d9b7d46b607d93824f69a Gerrit-Change-Number: 22118 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2024 23:14:01 +0000 Gerrit-HasComments: Yes
