Hello Andrew Sherman, Riza Suminto, Abhishek Rawat, Michael Smith, Impala 
Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22119

to look at the new patch set (#7).

Change subject: IMPALA-13536: Fix Workload Management Init Tests Issues
......................................................................

IMPALA-13536: Fix Workload Management Init Tests Issues

Several problems with the workload management code and
test_workload_mgmt_init.py tests have been uncovered by the Ozone
tests.

* test_create_on_version_1_0_0 - Test comment said it ran on 10
      nodes, test configuration specified 1 node. Fix was to modify
      the test configuration.
* test_create_on_version_1_1_0 - Test comment said it ran on 10
      nodes, test configuration specified 1 node. Fix was to modify
      the test configuration.
* test_invalid_* - All four of these tests run the same internal
      function to execute the test. This internal function was not
      waiting long enough for the expected failure to appear. The
      fixed internal function waits longer for the expected failure.

Additionally, the @CustomClusterTestSuite annotation has a new option
named 'log_symlinks', which, if set to True will resolve all daemon
log symlinks and output their actual paths to the log. Failed tests
can then be easily traced to the exact log files for that test.

The existing workload management tests in testdata have been expanded
to also assert the expected table properties are present.

Modified tests passed on Ozone builds both with and without erasure
coding enabled.

Change-Id: Ie3f34088d1d925f30abb63471387e6fdb62b95a7
---
D 
testdata/workloads/functional-query/queries/QueryTest/workload-management-log-v1.0.0.test
D 
testdata/workloads/functional-query/queries/QueryTest/workload-management-log-v1.1.0.test
R 
testdata/workloads/functional-query/queries/QueryTest/workload-mgmt-impala_query_live-v1.0.0.test
R 
testdata/workloads/functional-query/queries/QueryTest/workload-mgmt-impala_query_live-v1.1.0.test
A 
testdata/workloads/functional-query/queries/QueryTest/workload-mgmt-impala_query_log-v1.0.0.test
A 
testdata/workloads/functional-query/queries/QueryTest/workload-mgmt-impala_query_log-v1.1.0.test
M tests/common/custom_cluster_test_suite.py
M tests/custom_cluster/test_workload_mgmt_init.py
M tests/util/workload_management.py
9 files changed, 263 insertions(+), 244 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/22119/7
--
To view, visit http://gerrit.cloudera.org:8080/22119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3f34088d1d925f30abb63471387e6fdb62b95a7
Gerrit-Change-Number: 22119
Gerrit-PatchSet: 7
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>

Reply via email to