Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22119 )
Change subject: IMPALA-13536: Fix Workload Management Init Tests Issues ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/22119/5/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22119/5/tests/common/custom_cluster_test_suite.py@460 PS5, Line 460: # List log files from this cluster startup to identify log files for failed tests. > I don't see how this is limited to failed tests. It's only limited by the fact that succeeding tests hide all stdout/stderr. Comment removed. http://gerrit.cloudera.org:8080/#/c/22119/5/tests/custom_cluster/test_workload_mgmt_init.py File tests/custom_cluster/test_workload_mgmt_init.py: http://gerrit.cloudera.org:8080/#/c/22119/5/tests/custom_cluster/test_workload_mgmt_init.py@123 PS5, Line 123: def check_schema_version(self, schema_version, protocol=None): > Can this be a .test file instead? Please check some examples in testdata/ Good idea. I was able to expand the existing .test files to also validate the table properties. This change in turn allowed for the elimination of even more code. -- To view, visit http://gerrit.cloudera.org:8080/22119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f34088d1d925f30abb63471387e6fdb62b95a7 Gerrit-Change-Number: 22119 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 27 Nov 2024 22:15:46 +0000 Gerrit-HasComments: Yes
