Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22119 )

Change subject: IMPALA-13536: Fix Workload Management Init Tests Issues
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22119/7/tests/custom_cluster/test_workload_mgmt_init.py
File tests/custom_cluster/test_workload_mgmt_init.py:

http://gerrit.cloudera.org:8080/#/c/22119/7/tests/custom_cluster/test_workload_mgmt_init.py@150
PS7, Line 150:     self.restart_cluster(vector, schema_version="1.1.0", 
log_symlinks=True)
             :     self.check_schema("1.1.0", vector)
> Why schema_version property still exist in no_upgrade scenario?
The "schema_version" property is the old table property.  Since previous 
versions of workload management did not handle changes in this property value, 
I had to add the new property named "wm_schema_version" to maintain backwards 
compatibility.  For more details, see the comment at 
https://github.com/apache/impala/blob/79eb48e9f63a87bf240080949c11e90b47c1367f/be/src/catalog/workload-management-init.cc#L416-L418



--
To view, visit http://gerrit.cloudera.org:8080/22119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f34088d1d925f30abb63471387e6fdb62b95a7
Gerrit-Change-Number: 22119
Gerrit-PatchSet: 7
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Mon, 09 Dec 2024 19:55:09 +0000
Gerrit-HasComments: Yes

Reply via email to