Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22045 )
Change subject: IMPALA-13535: Add script to restore stats on PlannerTest ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/22045/9/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22045/9/bin/jenkins/critique-gerrit-review.py@381 PS9, Line 381: if os.path.splitext(path)[1] == ".test": At L397 we will discard all changes under testdata/ dir. I think we should remove this condition to protect changes on other files like txt files under testdata/data/ http://gerrit.cloudera.org:8080/#/c/22045/8/testdata/bin/restore-stats-on-planner-tests.py File testdata/bin/restore-stats-on-planner-tests.py: http://gerrit.cloudera.org:8080/#/c/22045/8/testdata/bin/restore-stats-on-planner-tests.py@37 PS8, Line 37: \d.* > Added requirement such that all tables subject to this script must have sta Ack http://gerrit.cloudera.org:8080/#/c/22045/8/testdata/bin/restore-stats-on-planner-tests.py@128 PS8, Line 128: > Limit to do replacement only if all partitions are selected. Ack -- To view, visit http://gerrit.cloudera.org:8080/22045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27bab7cee93880cd59f01b9c2d1614dfcabdc682 Gerrit-Change-Number: 22045 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 02 Dec 2024 21:10:22 +0000 Gerrit-HasComments: Yes
