Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22045 )
Change subject: IMPALA-13535: Add script to restore stats on PlannerTest ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/22045/8/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22045/8/bin/jenkins/critique-gerrit-review.py@382 PS8, Line 382: comments[path].append(get_comment_input(UNCOMMITTED_CHANGE)) > This discards all changes. To be safe, can we run "git diff" before this me Done http://gerrit.cloudera.org:8080/#/c/22045/8/testdata/bin/restore-stats-on-planner-tests.py File testdata/bin/restore-stats-on-planner-tests.py: http://gerrit.cloudera.org:8080/#/c/22045/8/testdata/bin/restore-stats-on-planner-tests.py@33 PS8, Line 33: \w+).( > Should we accept numbers in the names as well? Maybe use "\w"? Done http://gerrit.cloudera.org:8080/#/c/22045/8/testdata/bin/restore-stats-on-planner-tests.py@37 PS8, Line 37: \d.* > Do we have cases where this is not positive number but something like "unav Added requirement such that all tables subject to this script must have stats collected by default. Thus, there should be no "unavailable" or "-1" case. http://gerrit.cloudera.org:8080/#/c/22045/8/testdata/bin/restore-stats-on-planner-tests.py@128 PS8, Line 128: > In cases where not all the partitions are selected, is it correct to use th Limit to do replacement only if all partitions are selected. -- To view, visit http://gerrit.cloudera.org:8080/22045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27bab7cee93880cd59f01b9c2d1614dfcabdc682 Gerrit-Change-Number: 22045 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 02 Dec 2024 21:00:22 +0000 Gerrit-HasComments: Yes
