Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22045 )
Change subject: IMPALA-13535: Add script to restore stats on PlannerTest ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/22045/8/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22045/8/bin/jenkins/critique-gerrit-review.py@382 PS8, Line 382: check_call(['git', 'checkout', '.']) This discards all changes. To be safe, can we run "git diff" before this method and abort if there are already some uncommitted changes? http://gerrit.cloudera.org:8080/#/c/22045/8/testdata/bin/restore-stats-on-planner-tests.py File testdata/bin/restore-stats-on-planner-tests.py: http://gerrit.cloudera.org:8080/#/c/22045/8/testdata/bin/restore-stats-on-planner-tests.py@33 PS8, Line 33: [_a-z] Should we accept numbers in the names as well? Maybe use "\w"? http://gerrit.cloudera.org:8080/#/c/22045/8/testdata/bin/restore-stats-on-planner-tests.py@37 PS8, Line 37: \d.* Do we have cases where this is not positive number but something like "unavailable" or "-1"? http://gerrit.cloudera.org:8080/#/c/22045/8/testdata/bin/restore-stats-on-planner-tests.py@128 PS8, Line 128: stats[1] In cases where not all the partitions are selected, is it correct to use the table level size? -- To view, visit http://gerrit.cloudera.org:8080/22045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27bab7cee93880cd59f01b9c2d1614dfcabdc682 Gerrit-Change-Number: 22045 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 02 Dec 2024 19:03:40 +0000 Gerrit-HasComments: Yes
