Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22046 )
Change subject: IMPALA-13526: Fix Agg node creation order in DistributedPlanner ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/22046/4/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/22046/4/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@223 PS4, Line 223: // to the proper place in the distributed plan via transferConjuncts argument. > Is this comment still accurate? Edited the comment. http://gerrit.cloudera.org:8080/#/c/22046/4/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/22046/4/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@a1073 PS4, Line 1073: > I see you deprecated transferConjuncts. Correct. That is the bad behavior that I want to fix by passing transferredConjuncts during init call. http://gerrit.cloudera.org:8080/#/c/22046/4/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@1055 PS4, Line 1055: List<Expr> havingPredicates = node.conjuncts_; > nit: could you do Done -- To view, visit http://gerrit.cloudera.org:8080/22046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica8227fdc46a1ef59bef5ae5424ba3907827411d Gerrit-Change-Number: 22046 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 06 Dec 2024 21:10:00 +0000 Gerrit-HasComments: Yes
