Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22046 )
Change subject: IMPALA-13526: Fix Agg node creation order in DistributedPlanner ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/22046/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22046/9//COMMIT_MSG@9 PS9, Line 9: place nit. places http://gerrit.cloudera.org:8080/#/c/22046/9//COMMIT_MSG@10 PS9, Line 10: require nit. requires http://gerrit.cloudera.org:8080/#/c/22046/9/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/22046/9/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@1067 PS9, Line 1067: mergeAggNode.init Just curious if there's any difference in behavior when calling init() before or after setting the limit. It doesn't seem to be mentioned in the comments. If the order matters, could we add some comments here? -- To view, visit http://gerrit.cloudera.org:8080/22046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica8227fdc46a1ef59bef5ae5424ba3907827411d Gerrit-Change-Number: 22046 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 17 Dec 2024 09:08:25 +0000 Gerrit-HasComments: Yes
