Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22046 )
Change subject: IMPALA-13526: Fix Agg node creation order in DistributedPlanner ...................................................................... Patch Set 5: (2 comments) I agree that this patch is not narrow enough to reflect the title. I'll see if I can split it and repurpose IMPALA-13480 for the JIRA number. http://gerrit.cloudera.org:8080/#/c/22046/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22046/5//COMMIT_MSG@20 PS5, Line 20: This patch also fixes a bug where the cardinality estimate of MERGE > Why isn't this a separate ticket? I need to Enabling PlannerTestOption.VALIDATE_CARDINALITY in some test to verify this patch. However, they also reveals this issue introduced by IMPALA-13405. http://gerrit.cloudera.org:8080/#/c/22046/5/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/22046/5/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@276 PS5, Line 276: // DistributedPlanner.java may transfer conjunct to merge phase aggregation later. > Were these part of the parent patch, and you've moved them to this one? I moved them here since the fix share the same theme with this patch: transferring HAVING predicates incorrectly can change cardinality estimate in wrong way. -- To view, visit http://gerrit.cloudera.org:8080/22046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica8227fdc46a1ef59bef5ae5424ba3907827411d Gerrit-Change-Number: 22046 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 06 Dec 2024 23:20:25 +0000 Gerrit-HasComments: Yes
