Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22189 )
Change subject: IMPALA-13501: Clean up uncommitted Iceberg files after validation check failure ...................................................................... Patch Set 1: (5 comments) Thanks for this patch, it looks good. I only have a few questions. http://gerrit.cloudera.org:8080/#/c/22189/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22189/1//COMMIT_MSG@14 PS1, Line 14: cannot Nit: "could not". http://gerrit.cloudera.org:8080/#/c/22189/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22189/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7564 PS1, Line 7564: ImpalaRuntimeException Do we need to catch ImpalaRuntimeException here? Can a validation error also cause an ImpalaRuntimeException instead of a ValidationException? Or is ValidationException only used in the debug action? http://gerrit.cloudera.org:8080/#/c/22189/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22189/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@608 PS1, Line 608: List<String> pathStrings = new ArrayList<>(); Is there a reason for first collecting the paths and then deleting them? Couldn't we delete them "on-the-fly" in the FOR loops? http://gerrit.cloudera.org:8080/#/c/22189/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/22189/1/tests/query_test/test_iceberg.py@1999 PS1, Line 1999: table = "iceberg_cleanup_failure" Instead of 'table' and 'tbl_name', I think 'tbl_name' and 'fq_table_name' (or something similar) would be more correct as these two variables both hold table names. http://gerrit.cloudera.org:8080/#/c/22189/1/tests/query_test/test_iceberg.py@2007 PS1, Line 2007: self.client.execute("""CREATE TABLE {0} (i int) Is there a reason why this is not "execute_query_expect_success()"? -- To view, visit http://gerrit.cloudera.org:8080/22189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe59546ebf3c639b75b53dfa1daba37cef50eb21 Gerrit-Change-Number: 22189 Gerrit-PatchSet: 1 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2024 16:48:39 +0000 Gerrit-HasComments: Yes
