Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22189 )
Change subject: IMPALA-13501: Clean up uncommitted Iceberg files after validation check failure ...................................................................... Patch Set 2: (2 comments) The code looks good to me, looking forward for the stress test enhancements. http://gerrit.cloudera.org:8080/#/c/22189/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22189/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@607 PS1, Line 607: } > Is it ok to add it in CatalogOpExecutor after calling this function? I think it's fine until we start using this at other places where we have EventSequences. http://gerrit.cloudera.org:8080/#/c/22189/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22189/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@599 PS2, Line 599: for (ByteBuffer buf : icebergOp.getIceberg_delete_files_fb()) { : String pathString = FbIcebergDataFile.getRootAsFbIcebergDataFile(buf).path(); : if (pathString != null) { : deleteIfExists(new org.apache.hadoop.fs.Path((pathString))); : } : } nit: this duplicates L591-L597. Could be moved to a method that takes an Iterable<ByteBuffer> as parameter. -- To view, visit http://gerrit.cloudera.org:8080/22189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe59546ebf3c639b75b53dfa1daba37cef50eb21 Gerrit-Change-Number: 22189 Gerrit-PatchSet: 2 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 16 Dec 2024 17:57:24 +0000 Gerrit-HasComments: Yes
