Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22189 )
Change subject: IMPALA-13501: Clean up uncommitted Iceberg files after validation check failure ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22189/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22189/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7575 PS2, Line 7575: DebugUtils.executeDebugAction(update.getDebug_action(), DebugUtils.ICEBERG_COMMIT); There are two DebugUtils.executeDebugAction() in this function, and I think in cases where the second one would be triggered, the first will also be triggered, so the second will never actually run. -- To view, visit http://gerrit.cloudera.org:8080/22189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe59546ebf3c639b75b53dfa1daba37cef50eb21 Gerrit-Change-Number: 22189 Gerrit-PatchSet: 2 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 16 Dec 2024 14:21:46 +0000 Gerrit-HasComments: Yes
