Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22235
Change subject: IMPALA-13622: Fix negative cardinality bug in AggregationNode.java ...................................................................... IMPALA-13622: Fix negative cardinality bug in AggregationNode.java An incomplete COMPUTE STATS during data loading reveal a bug in AggregationNode.java where estimateNumGroups() can return value less than -1. This patch fix the bug by implementing PlanNode.smallestCardinality() function that correctly compares two cardinality numbers and return the smallest and valid one. Reorder logic of tuple-based estimation from IMPALA-13405 such that negative estimate is handled properly. Testing: - Added test in resource-requirements.test that will consistently fail without this fix. - Pass testResourceRequirement. Change-Id: Ib862a010b2094daa2cbdd5d555e46443009672ad --- M fe/src/main/java/org/apache/impala/planner/AggregationNode.java M fe/src/main/java/org/apache/impala/planner/PlanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test 3 files changed, 541 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/22235/1 -- To view, visit http://gerrit.cloudera.org:8080/22235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib862a010b2094daa2cbdd5d555e46443009672ad Gerrit-Change-Number: 22235 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]>
