Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22235 )
Change subject: IMPALA-13622: Fix negative cardinality bug in AggregationNode.java ...................................................................... Patch Set 1: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22235/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/22235/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@451 PS1, Line 451: long numGroupsForUniqueTuples = estimateNumGroups(exprsWithUniqueTupleId, aggInputCardinality); line too long (101 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib862a010b2094daa2cbdd5d555e46443009672ad Gerrit-Change-Number: 22235 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 18 Dec 2024 19:32:28 +0000 Gerrit-HasComments: Yes
