Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22235 )
Change subject: IMPALA-13622: Fix negative cardinality bug in AggregationNode.java ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22235/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/22235/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1417 PS2, Line 1417: > This function name does not fully describe what the function does. I think Done http://gerrit.cloudera.org:8080/#/c/22235/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1417 PS2, Line 1417: } > Please write junit tests for this new function. Added testSmallestValidCardinality. http://gerrit.cloudera.org:8080/#/c/22235/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1423 PS2, Line 1423: > Why is this function declared here instead of in AggregationNode? It's onl I think I hit this same issue somewhere else before. It is general enough to live inside PlanNode. ps3 replace capCardinalityAtLimit() calls with smallestValidCardinality(). -- To view, visit http://gerrit.cloudera.org:8080/22235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib862a010b2094daa2cbdd5d555e46443009672ad Gerrit-Change-Number: 22235 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 19 Dec 2024 19:47:48 +0000 Gerrit-HasComments: Yes
