Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22189 )
Change subject: IMPALA-13501: Clean up uncommitted Iceberg files after validation check failure ...................................................................... Patch Set 3: Code-Review+1 (2 comments) LGTM! http://gerrit.cloudera.org:8080/#/c/22189/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22189/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7561 PS3, Line 7561: DebugUtils.executeDebugAction( : update.getDebug_action(), DebugUtils.ICEBERG_CONFLICT); nit: this culd be moved before execute() * so it will be consistent with DebugUtils.ICEBERG_COMMIT * we won't create manifest files unnecessarily http://gerrit.cloudera.org:8080/#/c/22189/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22189/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@607 PS1, Line 607: > In case of exceptions, the Catalog timeline is not visible in the query pro I see, thanks for investigating this. -- To view, visit http://gerrit.cloudera.org:8080/22189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe59546ebf3c639b75b53dfa1daba37cef50eb21 Gerrit-Change-Number: 22189 Gerrit-PatchSet: 3 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 Dec 2024 14:25:46 +0000 Gerrit-HasComments: Yes
