Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 18: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21930/18/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: PS18: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new optional fields can be added. http://gerrit.cloudera.org:8080/#/c/21930/18/common/thrift/Frontend.thrift@643 PS18, Line 643: 2: required string requesting_user; Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/21930/18/common/thrift/Frontend.thrift@646 PS18, Line 646: 3: required bool is_admin; Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/21930/18/tests/common/cluster_config.py File tests/common/cluster_config.py: http://gerrit.cloudera.org:8080/#/c/21930/18/tests/common/cluster_config.py@28 PS18, Line 28: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/21930/18/tests/common/cluster_config.py@30 PS18, Line 30: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/21930/18/tests/query_test/test_kill_query.py File tests/query_test/test_kill_query.py: http://gerrit.cloudera.org:8080/#/c/21930/18/tests/query_test/test_kill_query.py@20 PS18, Line 20: from threading import Thread flake8: F401 'threading.Thread' imported but unused -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 18 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 30 Dec 2024 07:33:16 +0000 Gerrit-HasComments: Yes
