Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 17: (7 comments) http://gerrit.cloudera.org:8080/#/c/21930/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21930/13//COMMIT_MSG@27 PS13, Line 27: query we want to kill, we need to broadcast the kill request to all the > Thanks! Changed. Ack http://gerrit.cloudera.org:8080/#/c/21930/17/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21930/17/be/src/service/client-request-state.cc@2524 PS17, Line 2524: nullopt : I think the idea was that the KillQuery API would also have an is_admin parameter. I don't think it makes much sense to pass it, just to use it to nullify user again. http://gerrit.cloudera.org:8080/#/c/21930/17/be/src/service/client-request-state.cc@2538 PS17, Line 2538: *request.add_query_ids() = query_id_pb; This pattern looks weird, but I'm not very familiar with the protobuf classes. http://gerrit.cloudera.org:8080/#/c/21930/13/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/21930/13/be/src/service/impala-server.h@731 PS13, Line 731: > Thanks! Added ImpalaServer::KillQuery(). Ack http://gerrit.cloudera.org:8080/#/c/21930/13/common/protobuf/control_service.proto File common/protobuf/control_service.proto: http://gerrit.cloudera.org:8080/#/c/21930/13/common/protobuf/control_service.proto@470 PS13, Line 470: > Thanks! Added 'is_admin'. Ack http://gerrit.cloudera.org:8080/#/c/21930/13/fe/src/main/java/org/apache/impala/analysis/StatementBase.java File fe/src/main/java/org/apache/impala/analysis/StatementBase.java: http://gerrit.cloudera.org:8080/#/c/21930/13/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@283 PS13, Line 283: privilege > Thanks! Changed. Ack http://gerrit.cloudera.org:8080/#/c/21930/17/tests/util/cancel_util.py File tests/util/cancel_util.py: http://gerrit.cloudera.org:8080/#/c/21930/17/tests/util/cancel_util.py@23 PS17, Line 23: from tests.query_test.test_kill_query import assert_kill_ok I think this utility should live in this file, and test_kill_query should import it. It seems reasonable to me to move any utility functions here, rather than having one test import another test. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 17 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Sat, 21 Dec 2024 00:28:51 +0000 Gerrit-HasComments: Yes
