Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/21930/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21930/13//COMMIT_MSG@27 PS13, Line 27: coordinators in the cluster. Upon receiveing a kill request, each typo: receiving http://gerrit.cloudera.org:8080/#/c/21930/13/common/protobuf/control_service.proto File common/protobuf/control_service.proto: http://gerrit.cloudera.org:8080/#/c/21930/13/common/protobuf/control_service.proto@470 PS13, Line 470: optional string requesting_user = 2; > If that is the case, please have a dedicated boolean field 'is_admin'. That would make me feel better about the logic in ExecKillQuery. http://gerrit.cloudera.org:8080/#/c/21930/13/fe/src/main/java/org/apache/impala/analysis/KillQueryStmt.java File fe/src/main/java/org/apache/impala/analysis/KillQueryStmt.java: http://gerrit.cloudera.org:8080/#/c/21930/13/fe/src/main/java/org/apache/impala/analysis/KillQueryStmt.java@56 PS13, Line 56: if (authzConfig.isEnabled()) { If authz is not enabled, effectively all users are admins? -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 13 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 19 Dec 2024 21:59:21 +0000 Gerrit-HasComments: Yes
