Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22280 )

Change subject: IMPALA-13566: Expose query cancellation status to UDFs
......................................................................


Patch Set 3:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22280/3/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22280/3/tests/common/impala_connection.py@575
PS3, Line 575:
flake8: E261 at least two spaces before inline comment


http://gerrit.cloudera.org:8080/#/c/22280/3/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:

http://gerrit.cloudera.org:8080/#/c/22280/3/tests/query_test/test_cancellation.py@226
PS3, Line 226:
flake8: E261 at least two spaces before inline comment


http://gerrit.cloudera.org:8080/#/c/22280/3/tests/query_test/test_cancellation.py@228
PS3, Line 228:
flake8: E261 at least two spaces before inline comment



--
To view, visit http://gerrit.cloudera.org:8080/22280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9430167f7e46bbdf66153abb4645541cd8cf0142
Gerrit-Change-Number: 22280
Gerrit-PatchSet: 3
Gerrit-Owner: Xuebin Su <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 02 Jan 2025 07:12:41 +0000
Gerrit-HasComments: Yes

Reply via email to