Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22280 )
Change subject: IMPALA-13566: Expose query cancellation status to UDFs ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22280/3/be/src/exprs/utility-functions-ir.cc File be/src/exprs/utility-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/22280/3/be/src/exprs/utility-functions-ir.cc@171 PS3, Line 171: for (int remaining_sleep_duration = milliseconds.val; remaining_sleep_duration > 0; : remaining_sleep_duration -= SLEEP_UNINTERRUPTIBLE_INTERVAL_MS) { : if (ctx->IsQueryCancelled()) { : return BooleanVal(true); : } : SleepForMs(min(remaining_sleep_duration, SLEEP_UNINTERRUPTIBLE_INTERVAL_MS)); : } > Commenting on someone else's comment :) Thanks for noting that. My intention was also just to keep the sleep function precise, should not have phrased it as efficient. I was thinking the above first call within the if condition "(ctx->IsQueryCancelled())" would also run within each batch, resulting in no need for checking cancel. -- To view, visit http://gerrit.cloudera.org:8080/22280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9430167f7e46bbdf66153abb4645541cd8cf0142 Gerrit-Change-Number: 22280 Gerrit-PatchSet: 3 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Sun, 05 Jan 2025 20:06:25 +0000 Gerrit-HasComments: Yes
