Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22293 )
Change subject: IMPALA-13627: Handle legacy Hive timezone conversion ...................................................................... Patch Set 1: (16 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22293/1/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: PS1: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new optional fields can be added. http://gerrit.cloudera.org:8080/#/c/22293/1/common/thrift/Frontend.thrift@1081 PS1, Line 1081: 1: required i64 year Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/22293/1/common/thrift/Frontend.thrift@1082 PS1, Line 1082: 2: required i32 month Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/22293/1/common/thrift/Frontend.thrift@1083 PS1, Line 1083: 3: required i32 day Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/22293/1/common/thrift/Frontend.thrift@1084 PS1, Line 1084: 4: required i32 hour Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/22293/1/common/thrift/Frontend.thrift@1085 PS1, Line 1085: 5: required i32 minute Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/22293/1/common/thrift/Frontend.thrift@1086 PS1, Line 1086: 6: required i32 second Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/22293/1/tests/query_test/test_hive_timestamp_conversion.py File tests/query_test/test_hive_timestamp_conversion.py: http://gerrit.cloudera.org:8080/#/c/22293/1/tests/query_test/test_hive_timestamp_conversion.py@27 PS1, Line 27: class TestHiveParquetTimestampConversion(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22293/1/tests/query_test/test_hive_timestamp_conversion.py@36 PS1, Line 36: a flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22293/1/tests/query_test/test_hive_timestamp_conversion.py@54 PS1, Line 54: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22293/1/tests/query_test/test_hive_timestamp_conversion.py@91 PS1, Line 91: s flake8: E501 line too long (110 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22293/1/tests/query_test/test_hive_timestamp_conversion.py@95 PS1, Line 95: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22293/1/tests/query_test/test_hive_timestamp_conversion.py@102 PS1, Line 102: '1 1880-01-01 07:52:58', '2 1884-01-01 08:00:00', '3 1990-01-01 08:00:00'] tab used for whitespace http://gerrit.cloudera.org:8080/#/c/22293/1/tests/query_test/test_hive_timestamp_conversion.py@108 PS1, Line 108: '1 1880-01-01 00:00:00', '2 1884-01-01 00:00:00', '3 1990-01-01 00:00:00'] tab used for whitespace http://gerrit.cloudera.org:8080/#/c/22293/1/tests/query_test/test_hive_timestamp_conversion.py@114 PS1, Line 114: '1 1880-01-01 00:00:00', '2 1884-01-01 00:00:00', '3 1990-01-01 00:00:00'] tab used for whitespace http://gerrit.cloudera.org:8080/#/c/22293/1/tests/query_test/test_hive_timestamp_conversion.py@124 PS1, Line 124: + flake8: W504 line break after binary operator -- To view, visit http://gerrit.cloudera.org:8080/22293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1271ed1da0b74366ab8315e7ec2d4ee47111e067 Gerrit-Change-Number: 22293 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 03 Jan 2025 00:51:04 +0000 Gerrit-HasComments: Yes
